Skip to content

[Dashboard] Fix stripe redirect for onboarding flow #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

[Dashboard] Fix stripe redirect for onboarding flow #5499

merged 1 commit into from
Nov 22, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 22, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces a new redirectPath prop across several components in the onboarding and billing processes, enhancing navigation after actions are completed.

Detailed summary

  • Added redirectPath prop to LazyOnboardingUI in LoginPage.tsx.
  • Included redirectPath in OnboardingChoosePlan component.
  • Updated OnboardingUI to pass redirectPath to OnboardingChoosePlan.
  • Added redirectPath to PricingCard props.
  • Updated BillingPricing to include redirectPath when rendering PricingCard components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:02pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 22, 2024 8:02pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 22, 2024 8:02pm
wallet-ui ⬜️ Skipped (Inspect) Nov 22, 2024 8:02pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 19:34 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 91cea2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 19:34 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank changed the title Fix stripe redirect for onboarding flow [Dashboard] Fix stripe redirect for onboarding flow Nov 22, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Nov 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review November 22, 2024 19:34
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 534 ms (+30.41% 🔺) 1.5 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 1.2 s (+65.33% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 240 ms (+1653.82% 🔺) 352 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 98 ms (+1747.17% 🔺) 108 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 274 ms (+246.49% 🔺) 641 ms

@codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.85%. Comparing base (d9a63a6) to head (91cea2d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5499   +/-   ##
=======================================
  Coverage   43.85%   43.85%           
=======================================
  Files        1075     1075           
  Lines       55944    55944           
  Branches     3908     3908           
=======================================
  Hits        24534    24534           
  Misses      30727    30727           
  Partials      683      683
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d9a63a6
packages 38.58% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024 •
edited
Loading

Merge activity

@MananTank
[Dashboard] Fix stripe redirect for onboarding flow (#5499)
91cea2d 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on adding a `redirectPath` prop across various components in the onboarding and billing sections of the application, enhancing navigation after specific actions.

### Detailed summary
- Added `redirectPath` prop to `LazyOnboardingUI` in `LoginPage.tsx`.
- Introduced `redirectPath` in `OnboardingChoosePlan` component.
- Passed `redirectPath` from `OnboardingUI` to `OnboardingChoosePlan`.
- Updated `PricingCard` to accept and utilize `redirectPath`.
- Implemented `redirectPath` in the `BillingPricing` component for `PricingCard` instances.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-23-fix_stripe_redirect_for_onboarding_flow branch from fb1e5d4 to 91cea2d Compare November 22, 2024 19:59
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 22, 2024 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 22, 2024 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 22, 2024 19:59 Inactive
@graphite-app graphite-app bot merged commit 91cea2d into main Nov 22, 2024
27 of 28 checks passed
@graphite-app graphite-app bot deleted the 11-23-fix_stripe_redirect_for_onboarding_flow branch November 22, 2024 20:03
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 22, 2024 20:03 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 22, 2024 20:03 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 22, 2024 20:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls